Clean head tags, change doctype to html5 and merge inlinejs.php with pp-ui-behavior.js #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cify internationalised or url-based properties, use scripts from pp-ui-behavior.js
|
OK, this all looks great. I was in particular impressed with what you did with the pp-ui-behavior.js and inline js.php files. I can't auto-merge cause of some changes I did earlier, but I will merge manually. Thanks for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed the way titles are formed to make it more uniform (always end with the site name, instead of switching between site and company).
You might consider merging the affected layout files (or parts of them) to allow for easier editing.
Furthermore, validation highlighted that ampersands in links aren't escaped, needs to be further looked into.